Allow passing an iterable to splice_children
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
approved these changes
Jun 25, 2024
michaelvanstraten
force-pushed
the
allow-passing-an-iterable-to-splice-children
branch
from
e442c37
to
faee543
Compare
|
@lnicola, sorry for the delay, I've bumped the version number. |
|
@Veykril can you also review and merge this? I assume bumping the crate version would also have been required for my PR, so getting this in here instead would solve this too. |
|
This needs a minor version bump, the signature change here could break callers |
Yes, you are right, for somebody passing an induced type via |
michaelvanstraten
force-pushed
the
allow-passing-an-iterable-to-splice-children
branch
from
faee543
to
dc1eb13
Compare
|
@Veykril is updated. |
|
@Veykril ping? can this be merged now and a new release be tagged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should reduce two allocation when splicing children.